From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics Date: Fri, 22 Mar 2019 18:17:22 +0100 Message-ID: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, stable@dpdk.org To: David Marchand , dev@dpdk.org Return-path: In-Reply-To: <1553261824-1881-2-git-send-email-david.marchand@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/22/19 2:37 PM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > After: > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > Fixes: af75078fece3 ("first public release") > Cc:stable@dpdk.org While the patch is good, I wonder whether we should backport it. Indeed, it might break some scripts parsing testpmd output. Any thoughts? > Signed-off-by: David Marchand > Reviewed-by: Rami Rosen > Reviewed-by: Andrew Rybchenko > --- > Changelog since v2: > - Cc'd stable > > ---