From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v3] mempool: rename functions with confusing names Date: Fri, 1 Jul 2016 10:57:24 +0200 Message-ID: <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> <1613474.aBI9rN0qDz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, keith.wiles@intel.com, Panu Matilainen To: Thomas Monjalon , Bruce Richardson Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 15A3D2C2C for ; Fri, 1 Jul 2016 10:57:26 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id v199so17675390wmv.0 for ; Fri, 01 Jul 2016 01:57:26 -0700 (PDT) In-Reply-To: <1613474.aBI9rN0qDz@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/30/2016 10:05 PM, Thomas Monjalon wrote: > 2016-06-30 13:49, Bruce Richardson: >> The mempool_count and mempool_free_count behaved contrary to what their >> names suggested. The free_count function actually returned the number of >> elements that were allocated from the pool, not the number unallocated as >> the name implied. >> >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count >> >> In this patch, the new functions are added, and the old ones are marked >> as deprecated. All apps and examples that use the old functions are >> updated to use the new functions. > > The ThunderX driver uses rte_mempool_count and needs an update. > Except that, it looks good. > Yep, I don't see any other issue.