From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet
	Rx queues
Date: Mon, 14 Aug 2017 14:18:15 +0530
Message-ID: <3fe6768a-7422-8006-5d37-961b0b31afa3@intel.com>
References: <20170713184445.GA3659@jerin>
 <123ed8d6-4fd9-8bee-d86e-d270a092169e@intel.com>
 <20170729151252.GA25166@jerin>
 <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com>
 <20170801164242.GA6467@jerin>
 <9184057F7FC11744A2107296B6B8EB1E01F00701@FMSMSX108.amr.corp.intel.com>
 <20170803062315.GA14704@jerin>
 <9184057F7FC11744A2107296B6B8EB1E01F030FC@FMSMSX108.amr.corp.intel.com>
 <20170809161946.GA6650@jerin>
 <9184057F7FC11744A2107296B6B8EB1E01F0EEF4@FMSMSX108.amr.corp.intel.com>
 <20170810165319.GA6051@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
 "Vangati, Narender" <narender.vangati@intel.com>,
 "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 "Eads, Gage" <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5E1697D72
 for <dev@dpdk.org>; Mon, 14 Aug 2017 10:48:19 +0200 (CEST)
In-Reply-To: <20170810165319.GA6051@jerin>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/10/2017 10:23 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Wed, 9 Aug 2017 19:24:30 +0000
>> From: "Eads, Gage" <gage.eads@intel.com>
>> Makes sense. Are you thinking the helper function would do stop + reconfig with additional port + start + setup port, or just setup the port with an ID the app supplies (only when a port is required, of course)? The second one could be done with little additional code -- the app just needs to check if an additional port is needed when configuring the eventdev, and another helper function could take a list of <eventdev, ethdev> pairs and return true if any don't have an inbuilt port.
> 
> I am in favor adding more logic in helper function(I believe, first one ) so that it will help
> application reuse the helper functions for the normal case.
> 

Hi Jerin,

My understanding of the discussion above is that the simple API adapter 
creation API is

int rte_event_eth_rx_adapter_create(id, eventdev_id)

And the raw API is

typedef int (*rx_adapter_conf_cb) (id, eventdev_id,
	struct rte_event_eth_rx_adapter_conf *conf, void *arg);

struct rte_event_eth_rx_adapter_conf {
	uint8_t rx_event_port_id;
	uint32_t max_nb_rx;
};

int rte_event_eth_rx_adapter_create_ext(id, eventdev_id, conf_cb,
					conf_arg)

The conf_cb is invoked if the rte_event_eth_rx_adapter_conf struct needs 
to be filled out. the _create_ext() API is used internally by 
rte_event_eth_rx_adapter_create()

Does that look OK to you ?

Nikhil