From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/mlx4: improve Rx packet type offloads
	report
Date: Wed, 08 Nov 2017 20:56:03 +0100
Message-ID: <4000150.53I7WZDMbS@xps>
References: <1510166831-153992-1-git-send-email-motih@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com
To: Moti Haimovsky <motih@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C9D2C1B283
 for <dev@dpdk.org>; Wed,  8 Nov 2017 20:56:04 +0100 (CET)
In-Reply-To: <1510166831-153992-1-git-send-email-motih@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/11/2017 19:47, Moti Haimovsky:
> This patch improves Rx packet type offload report in case the device is
> a virtual function device.
> In these devices we observed that the L2 tunnel flag is set also for
> non-tunneled packets, this leads to a complete misinterpretation of the
> packet type being received.
> This issue occurs since the tunnel_mode is not set to 0x7 by the driver
> for virtual devices and therefore the value in the L2 tunnel flag is
> meaningless and should be ignored.
> 
> Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads")
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> V2:
> Modification according to inputs from Adrien Mazarguil
> * Modified the commit message to explain the issue.
> * Removed redundant l2 tunnel offload bit.
> * Modified mlx4_dev_supported_ptypes_get to report the supported
>   packet types according to the device in hand.
> ---

As it is a v2, it should be threaded with v1.
Please remind to use --in-reply-to.

Just looking at the title, we should not take it for RC3.
But reading the commit message, especially "this leads to a
complete misinterpretation of the packet type being received",
it appears fixing a real bug. In this case, the title should be
	"net/mlx4: fix Rx packet type offloads"