From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header Date: Wed, 21 May 2014 18:07:37 +0200 Message-ID: <4002874.rX8l5tMzHC@xps13> References: <1400514709-24087-8-git-send-email-anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Anatoly Burakov Return-path: In-Reply-To: <1400514709-24087-8-git-send-email-anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-19 16:51, Anatoly Burakov: > Creating code to handle VFIO interrupts in EAL interrupts, and also > adding a header eal_vfio.h. Maybe it's better to have 2 patches here. > This header checks two things: > * checks if CONFIG_RTE_EAL_VFIO was enabled during build time > * checks that kernel version is 3.6+ so that DPDK would still compile > on older kernels despite VFIO compilation being enabled by default. In case VFIO is backported on older kernel, it would be better to check a related macro instead of Linux version. > This header also defines a VFIO_PRESENT macro, which should be used to > conditionally compile all the VFIO code. This is because having > CONFIG_RTE_EAL_VFIO enabled doesn't guarantee that the VFIO support is > compiled in, because we're still dependent on kernel version. > > Signed-off-by: Anatoly Burakov > + struct vfio_irq_set * irq_set; There few lines like this one where checkpatch.pl reports an error: ERROR: "foo * bar" should be "foo *bar" Thanks -- Thomas