From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] kni: fix compile issue on Ubuntu 12.04 with kernel 3.13.0-30 Date: Tue, 24 Nov 2015 21:36:33 +0100 Message-ID: <4010980.uDg8NWFa2X@xps13> References: <1448384381-203269-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 5681B8E83 for ; Tue, 24 Nov 2015 21:37:51 +0100 (CET) Received: by wmuu63 with SMTP id u63so112631184wmu.0 for ; Tue, 24 Nov 2015 12:37:51 -0800 (PST) In-Reply-To: <1448384381-203269-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-24 16:59, Pablo de Lara: > Fixes following error when Ubuntu 12.04 uses kernel 3.13.0-30-generic= , > since skb_set_hash() is implemented in the kernel from 3.13.0-30, > which is declared as UBUNTU_KERNEL_VERSION(3,13,0,30,0) and not > UBUNTU_KERNEL_VERSION(3,13,0,30,54) >=20 > In file included > from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.= h:23:0, > from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:= 39, > from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31,= > from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31= , > from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mbx.h:31= , > from /tmp/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxa= pp/kni/e1000_mbx.c:28: > /usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1= : > note: previous definition of =E2=80=98skb_set_hash=E2=80=99 was here > skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types ty= pe) > ^ >=20 > Fixes: e88c3b0a ("kni: fix build on Ubuntu 12.04.5") >=20 > Signed-off-by: Pablo de Lara Applied, thanks