[PATCH] Use proper mac type for 82576 VF

[PATCH] Use proper mac type for 82576 VF

[Konstantin Ananyev]

e1000_vfadapt type corresponds to 82576 VF devices,
check e1000_set_mac_type() for more details.
---
 lib/librte_pmd_e1000/igb_rxtx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
index 6b454a5..7fe1780 100644
--- a/lib/librte_pmd_e1000/igb_rxtx.c
+++ b/lib/librte_pmd_e1000/igb_rxtx.c
@@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
 		rxdctl &= 0xFFF00000;
 		rxdctl |= (rxq->pthresh & 0x1F);
 		rxdctl |= ((rxq->hthresh & 0x1F) << 8);
-		if (hw->mac.type == e1000_82576) {
+		if (hw->mac.type == e1000_vfadapt) {
 			/* 
 			 * Workaround of 82576 VF Erratum
 			 * force set WTHRESH to 1 
-- 
1.7.7.6

Re: [PATCH] Use proper mac type for 82576 VF

[Thomas Monjalon]

Hi Konstantin,

2014-05-06 12:28, Konstantin Ananyev:
> e1000_vfadapt type corresponds to 82576 VF devices,
> check e1000_set_mac_type() for more details.

You forgot "Signed-off-by:" line.
Please resend.

-- 
Thomas

Re: [PATCH] Use proper mac type for 82576 VF

[Ananyev, Konstantin]

Hi Thomas,
I believe I already resent it with signed-off-by.
Thanks
Konstantin

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] 
Sent: Thursday, May 22, 2014 4:33 PM
To: Ananyev, Konstantin
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF

Hi Konstantin,

2014-05-06 12:28, Konstantin Ananyev:
> e1000_vfadapt type corresponds to 82576 VF devices,
> check e1000_set_mac_type() for more details.

You forgot "Signed-off-by:" line.
Please resend.

-- 
Thomas

Re: [PATCH] Use proper mac type for 82576 VF

[Thomas Monjalon]

2014-05-22 15:39, Ananyev, Konstantin:
> Hi Thomas,
> I believe I already resent it with signed-off-by.

Oh yes, you're right.
Sorry for the noise.


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Thursday, May 22, 2014 4:33 PM
> To: Ananyev, Konstantin
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
> 
> Hi Konstantin,
> 
> 2014-05-06 12:28, Konstantin Ananyev:
> > e1000_vfadapt type corresponds to 82576 VF devices,
> > check e1000_set_mac_type() for more details.
> 
> You forgot "Signed-off-by:" line.
> Please resend.

[PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details.

[Konstantin Ananyev]

Signed-off-by: Konstantin Ananyev <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_pmd_e1000/igb_rxtx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
index 6b454a5..7fe1780 100644
--- a/lib/librte_pmd_e1000/igb_rxtx.c
+++ b/lib/librte_pmd_e1000/igb_rxtx.c
@@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
 		rxdctl &= 0xFFF00000;
 		rxdctl |= (rxq->pthresh & 0x1F);
 		rxdctl |= ((rxq->hthresh & 0x1F) << 8);
-		if (hw->mac.type == e1000_82576) {
+		if (hw->mac.type == e1000_vfadapt) {
 			/* 
 			 * Workaround of 82576 VF Erratum
 			 * force set WTHRESH to 1 
-- 
1.7.7.6

Re: [PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details.

[Ivan Boule]

On 05/06/2014 04:33 PM, Konstantin Ananyev wrote:
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>   lib/librte_pmd_e1000/igb_rxtx.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
> index 6b454a5..7fe1780 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
>   		rxdctl &= 0xFFF00000;
>   		rxdctl |= (rxq->pthresh & 0x1F);
>   		rxdctl |= ((rxq->hthresh & 0x1F) << 8);
> -		if (hw->mac.type == e1000_82576) {
> +		if (hw->mac.type == e1000_vfadapt) {
>   			/*
>   			 * Workaround of 82576 VF Erratum
>   			 * force set WTHRESH to 1

Acked.

Thanks.

-- 
Ivan Boule
6WIND Development Engineer

Re: [PATCH] Use proper mac type for 82576 VF

[Thomas Monjalon]

> > e1000_vfadapt type corresponds to 82576 VF devices,
> > check e1000_set_mac_type() for more details.
> > 
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Ivan Boule <ivan.boule-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied for version 1.7.0 with title:
	igbvf: fix mac type for 82576

Thanks
-- 
Thomas