From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 04/16] Make igb_uio compilation optional Date: Tue, 27 May 2014 10:49:01 +0200 Message-ID: <4015459.eKTdkh5M37@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi HuilongX, I have few comments. 2014-05-27 02:43, Xu, HuilongX: > Currently, igb_uio is always compiled. Some Linux distribution may > not want to include igb_uio by default, so we need to make sure that > igb_uio compilation can be optional. 1) When replying to an email, there should be "> " in front of lines you have not written. Here, it's not easy to see what you are replying. > Signed-off-by: Anatoly Burakov > > > Test-by: HuilongX Xu > > Compile > pass > > >>Compile OS: FC20 x86_64 > >>Kernel version: 3.13.6-200 > >>GCC version: 4.8.2 > >>Server: Crownpass 2) Please do not copy all the patch if you have nothing specific to say about it. -- Thomas