From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] ipc: fix locking while sending messages Date: Fri, 29 Jun 2018 02:02:38 +0200 Message-ID: <4017209.qn6vUfZg5o@xps> References: <164824cc66c16755416bb8d3d6911385f52f8c1e.1530092380.git.anatoly.burakov@intel.com> <039ED4275CED7440929022BC67E706115323F36E@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, "Zhang, Qi Z" , "dev@dpdk.org" To: "Burakov, Anatoly" Return-path: In-Reply-To: <039ED4275CED7440929022BC67E706115323F36E@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/06/2018 14:25, Zhang, Qi Z: > From: Burakov, Anatoly > > > > Previously, we were putting an exclusive lock to prevent secondary processes > > spinning up while we are sending our messages. However, using exclusive > > locks had an effect of disallowing multiple simultaenous unrelated > > messages/requests being sent, which was not the intention behind locking. > > > > Fix it to put a shared lock on the directory. That way, we still prevent > > secondary process initializations while sending data over IPC, but allow > > multiple unrelated transmissions to proceed. > > > > Fixes: 89f1fe7e6d95 ("eal: lock IPC directory on init and send") > > Cc: stable@dpdk.org > > > > Signed-off-by: Anatoly Burakov > > Tested-by: Qi Zhang > > Thanks for the quick fix! > Qi Applied, thanks