From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v2 2/2] ethdev: introduce Tx queue offloads
	API
Date: Tue, 12 Sep 2017 17:43:56 +0300
Message-ID: <4027c960-f98f-df72-a12e-65545ca87cb5@solarflare.com>
References: <20170911090543.GA9965@jerin>
 <2601191342CEEE43887BDE71AB9772584F2497DC@irsmsx105.ger.corp.intel.com>
 <20170912040107.GA8081@jerin>
 <VI1PR05MB3149DA3533771F6CAC410FB7C3690@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <20170912055137.GA24921@jerin>
 <VI1PR05MB3149BFE963A2D760B663F926C3690@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <20170912071735.GA29366@jerin>
 <VI1PR05MB31495E6EB625CF83FEA40887C3690@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <66688482-9e4e-81d5-195a-6f1a74caca73@solarflare.com>
 <2601191342CEEE43887BDE71AB9772584F249FFC@irsmsx105.ger.corp.intel.com>
 <20170912143630.GA23129@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Shahaf Shuler <shahafs@mellanox.com>, Stephen Hemminger
 <stephen@networkplumber.org>, Thomas Monjalon <thomas@monjalon.net>,
 "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 470FC1041
 for <dev@dpdk.org>; Tue, 12 Sep 2017 16:44:09 +0200 (CEST)
In-Reply-To: <20170912143630.GA23129@jerin>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/12/2017 05:36 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Tue, 12 Sep 2017 14:26:38 +0000
>> From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
>> To: Andrew Rybchenko <arybchenko@solarflare.com>, Shahaf Shuler
>>   <shahafs@mellanox.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> CC: Stephen Hemminger <stephen@networkplumber.org>, Thomas Monjalon
>>   <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin"
>>   <helin.zhang@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads
>>   API
>>
>>
>>
>>> -----Original Message-----
>>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>>> Sent: Tuesday, September 12, 2017 11:28 AM
>>> To: Shahaf Shuler <shahafs@mellanox.com>; Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stephen Hemminger <stephen@networkplumber.org>; Thomas Monjalon
>>> <thomas@monjalon.net>; dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>>> Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API
>>>
>>> On 09/12/2017 11:03 AM, Shahaf Shuler wrote:
>>>> OK, well understood the requirement for such flags. Thanks for your replies.
>>>>
>>>> I think that for simplicity I will add two more flags on the Tx offloads capabilities:
>>>>
>>>> DEV_TX_OFFLOADS _MULTI_MEMPOOL <** Device supports transmission of mbufs from multiple mempools. */
>>>> DEV_TX_OFFLOADS_INDIRECT_MBUFS <** Device support transmission of indirect mbufs. */
>>> Indirect mbufs is just an example when reference counters are required.
>>> Direct mbufs may use reference counters as well.
>> Personally, I still in favor to move these 2 flags away from TX_OFFLOADS.
>> But if people think it would be really helpfull to keep them, should we have then:
>> DEV_TX_OFFLOADS_FAST_FREE (or whatever then name will be) -
>> it would mean the same what (NOMULTIMEMP | NOREFCOUNT) means now.
> I am not too concerned about name. Yes. it should mean exiting (NOMULTIMEMP |
> NOREFCOUNT)

Merging these two flags together is OK for me as well.