From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 2/2] ethdev: remove old flow director symbols
Date: Tue, 15 Dec 2015 13:15:06 +0100
Message-ID: <40293176.xbuDhvPVS6@xps13>
References: <1450176434-7213-1-git-send-email-thomas.monjalon@6wind.com>
 <1450176434-7213-2-git-send-email-thomas.monjalon@6wind.com>
 <566FFC81.2010601@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id D9AE111A2
 for <dev@dpdk.org>; Tue, 15 Dec 2015 13:16:22 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id p66so87896512wmp.0
 for <dev@dpdk.org>; Tue, 15 Dec 2015 04:16:22 -0800 (PST)
In-Reply-To: <566FFC81.2010601@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-15 13:41, Panu Matilainen:
> On 12/15/2015 12:47 PM, Thomas Monjalon wrote:
> > The API has been removed but the symbols were still declared in the map.
> >
> > Fixes: a421b86a4a02 ("ethdev: remove old flow director API")
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >   lib/librte_ether/rte_ether_version.map | 8 --------
> >   1 file changed, 8 deletions(-)
> >
> > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> > index 17a11c7..d8db24d 100644
> > --- a/lib/librte_ether/rte_ether_version.map
> > +++ b/lib/librte_ether/rte_ether_version.map
> > @@ -27,14 +27,6 @@ DPDK_2.2 {
> >   	rte_eth_dev_count;
> >   	rte_eth_dev_default_mac_addr_set;
> >   	rte_eth_dev_detach;
> > -	rte_eth_dev_fdir_add_perfect_filter;
> > -	rte_eth_dev_fdir_add_signature_filter;
> > -	rte_eth_dev_fdir_get_infos;
> > -	rte_eth_dev_fdir_remove_perfect_filter;
> > -	rte_eth_dev_fdir_remove_signature_filter;
> > -	rte_eth_dev_fdir_set_masks;
> > -	rte_eth_dev_fdir_update_perfect_filter;
> > -	rte_eth_dev_fdir_update_signature_filter;
> >   	rte_eth_dev_filter_ctrl;
> >   	rte_eth_dev_filter_supported;
> >   	rte_eth_dev_flow_ctrl_get;
> >
> 
> Good spotting. What did you use find these and the ones in eal? Just 
> thinking this seems like something that could and should be automated.

Yes, it must be automated.
There are also some symbols which are defined in headers and do not need
to be in the .map. I'll send more cleanup and the script in the coming days
(for 2.3).