From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 1/2] ethdev: add buffered tx api
Date: Thu, 10 Mar 2016 17:23:55 +0100
Message-ID: <4053591.4SyQbLBBNH@xps13>
References: <1456333729-3804-1-git-send-email-tomaszx.kulasek@intel.com>
 <1457607478-2184-1-git-send-email-tomaszx.kulasek@intel.com>
 <1457607478-2184-2-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id C567D5588
 for <dev@dpdk.org>; Thu, 10 Mar 2016 17:25:38 +0100 (CET)
Received: by mail-wm0-f50.google.com with SMTP id l68so38001954wml.0
 for <dev@dpdk.org>; Thu, 10 Mar 2016 08:25:38 -0800 (PST)
In-Reply-To: <1457607478-2184-2-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-10 11:57, Tomasz Kulasek:
> +struct rte_eth_dev_tx_buffer {
> +	buffer_tx_error_fn callback;
> +	void *userdata;

What about renaming this fields as
- error_callback
- error_userdata ?

> +	uint16_t size;           /**< Size of buffer for buffered tx */
> +	uint16_t length;

Maybe a comment "Number of packets in the array" to be sure?

> +	struct rte_mbuf *pkts[];

A comment? "Pending packets to be sent on explicit flush or when full" ?

[...]
> +DPDK_16.04 {
> +	global:
> +
> +	rte_eth_tx_buffer_drop_callback;
> +	rte_eth_tx_buffer_count_callback;
> +	rte_eth_tx_buffer_init;
> +	rte_eth_tx_buffer_set_err_callback;

Please keep alphabetical order.