From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.
Date: Wed, 17 Jun 2015 14:30:55 +0200
Message-ID: <4065601.TTgiMRsfyC@xps13>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <cover.1433164517.git.rahul.lakkireddy@chelsio.com>
 <2e5139b0b03cdd49ad41feb8d3747d6d10f35255.1433164517.git.rahul.lakkireddy@chelsio.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 964FDC3C0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 14:31:56 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so132011707wiw.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 05:31:56 -0700 (PDT)
In-Reply-To: <2e5139b0b03cdd49ad41feb8d3747d6d10f35255.1433164517.git.rahul.lakkireddy@chelsio.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

It doesn't build as a shared library.
Please add EXPORT_MAP and LIBABIVER to the Makefile.
It would be easier to test if build config was merged in this patch,
with the Makefile.

Please merge also the maintainer infos.

2015-06-01 23:00, Rahul Lakkireddy:
> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))

RTE_DIM may be used