From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal/vfio: fix sPAPR IOMMU mapping
Date: Mon, 06 Aug 2018 11:50:56 +0200
Message-ID: <4068541.lKVHRX04u0@xps>
References: <20180806084309.5489-1-tyos@jp.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Takeshi Yoshimura <tyos@jp.ibm.com>,
 Takeshi Yoshimura <t.yoshimura8869@gmail.com>
To: anatoly.burakov@intel.com, chaozhu@linux.vnet.ibm.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CBB021B47E
 for <dev@dpdk.org>; Mon,  6 Aug 2018 11:51:02 +0200 (CEST)
In-Reply-To: <20180806084309.5489-1-tyos@jp.ibm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/08/2018 10:43, Takeshi Yoshimura:
> Commit 73a639085938 ("vfio: allow to map other memory regions")
> introduced a bug in sPAPR IOMMU mapping. The commit removed necessary
> ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk
> should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map.

This is fixing an old patch:
	http://git.dpdk.org/dpdk/commit/?id=73a639085938

> Fixes: 73a639085938 ("vfio: allow to map other memory regions")

You probably want it to be backported in previous release,
so you need to add Cc: stable@dpdk.org

> Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>

It is common to have bugs in sPAPR implementation.
How can we be sure this one is OK?
Should it be added in last minute of 18.08?
Or can it wait 18.11?

Adding Anatoly and Chao who are maintainers to decide.