librte_power/rte_power.h causes link error

librte_power/rte_power.h causes link error

[Ильдар Мустафин]

 Hi list,

I got " multiple definition of 'rte_power_freq_min' " link error, while compiling my dpdk project.
I think extern keyword was missed in rte_power.h header for some reason:

/**
 * Scale down the frequency of a specific lcore to the lowest according to the
 * available frequencies.
 * Review each environments specific documentation for usage..
 *
 * @param lcore_id
 *  lcore id.
 *
 * @return
 *  - 1 on success with frequency changed.
 *  - 0 on success without frequency changed.
 *  - Negative on error.
 */
rte_power_freq_change_t rte_power_freq_min;


Thanks, 
Ildar

Re: librte_power/rte_power.h causes link error

[Thomas Monjalon]

Hi,

2015-01-19 16:55, Ильдар Мустафин:
>  Hi list,
> 
> I got " multiple definition of 'rte_power_freq_min' " link error, while compiling my dpdk project.
> I think extern keyword was missed in rte_power.h header for some reason:

You're right.
It can be seen in this commit:
	http://dpdk.org/browse/dpdk/commit/lib/librte_power/rte_power.h?id=445c6528b55f9025

Thanks for reporting
-- 
Thomas

[PATCH] power: added missing extern keyword in rte_power.h

[Pablo de Lara]

rte_power_freq_min function did not include "extern" keyword,
causing linking errors.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Reported-by: Ildar Mustafin <imustafin-5URONGGNgjI@public.gmane.org>
---
 lib/librte_power/rte_power.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h
index 9338069..7d57359 100644
--- a/lib/librte_power/rte_power.h
+++ b/lib/librte_power/rte_power.h
@@ -242,7 +242,7 @@ extern rte_power_freq_change_t rte_power_freq_max;
  *  - 0 on success without frequency changed.
  *  - Negative on error.
  */
-rte_power_freq_change_t rte_power_freq_min;
+extern rte_power_freq_change_t rte_power_freq_min;
 
 #ifdef __cplusplus
 }
-- 
1.7.4.1

Re: [PATCH] power: added missing extern keyword in rte_power.h

[Thomas Monjalon]

> rte_power_freq_min function did not include "extern" keyword,
> causing linking errors.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reported-by: Ildar Mustafin <imustafin-5URONGGNgjI@public.gmane.org>

Fixes: 445c6528b55f ("power: common interface for guest and host")
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied

Thanks
-- 
Thomas