From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5] lib/metrics: add unregister api for
	metrics
Date: Tue, 02 Apr 2019 02:30:00 +0200
Message-ID: <4081359.dCFH9vKgjk@xps>
References: <1550849955-15101-1-git-send-email-wan.junjie@foxmail.com>
 <1551287944-27314-1-git-send-email-wan.junjie@foxmail.com>
 <1959572.AyLBI85xDo@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, remy.horton@intel.com
To: Junjie Wan <wan.junjie@foxmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 70A7F37A8
 for <dev@dpdk.org>; Tue,  2 Apr 2019 02:30:03 +0200 (CEST)
In-Reply-To: <1959572.AyLBI85xDo@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/04/2019 02:27, Thomas Monjalon:
> 27/02/2019 18:19, Junjie Wan:
> > From: junka <wan.junjie@foxmail.com>
> > 
> > The bitmap will help maintain the metrics. We can dynamically
> > add and remove metrics data. For example, after uninit latency lib,
> > it could remove itself from the metrics. This could make the result
> > from rte_metrics_get_names much more simple to display the wanted
> > metrics data only.
> > 
> > Signed-off-by: Junjie Wan <wan.junjie@foxmail.com>
> > ---
> > --- a/lib/librte_metrics/rte_metrics.h
> > +++ b/lib/librte_metrics/rte_metrics.h
> >  /**
> > + * Unregister set of metrics.
> > + *
> > + * Remove the metrics previously registered
> > + *
> > + * @param key
> > + *   Id of metrics to remove
> > + *
> > + * @param count
> > + *   Number of metrics
> > + *
> > + * @return
> > + *  - Zero: Success
> > + *  - -EIO: Error, unable to access metrics shared memory
> > + *    (rte_metrics_init() not called)
> > + *  - -EINVAL: Error, invalid parameters
> > + *  - -ERANGE: Error, oversized
> > + */
> > +int
> > +rte_metrics_unreg_values(uint16_t key, uint16_t count);
> 
> The rule is to add new API as experimental for some time.
> Please check how other new API functions are introduced.
> 
> You will need to add the function in rte_metrics_version.map
> to make it work in a shared library.

Few more requests:

Please would you like to add a test in app/test/test_metrics.c?
And maybe add some words in doc/guides/prog_guide/metrics_lib.rst?

Thanks