From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] buildtools: fix icc build Date: Mon, 06 Nov 2017 21:45:18 +0100 Message-ID: <4092310.7GeyUAk7Gr@xps> References: <20171102002510.26917-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D06F523A for ; Mon, 6 Nov 2017 21:45:19 +0100 (CET) In-Reply-To: <20171102002510.26917-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2017 01:25, Ferruh Yigit: > There are random build errors in test reports [1]. Build error > is not directly related to DPDK but observed during DPDK build. >=20 > When I get similar unexpected build errors in my system, found > out that /dev/null is invalid. >=20 > It seems ICC overwrites the /dev/null with "icc -o /dev/null" instead > of sending output to /dev/null. This is not always reproducible, so > hard to say what exactly is triggering the error. >=20 > I suspect test-report build errors can be because of the same reason, > and it is good to add a protection for this case. >=20 > Instead of sending output to /dev/null save it to the tmp folder and > remove it back when done. >=20 > [1] > http://dpdk.org/ml/archives/test-report/2017-November/034053.html > Failure #3 >=20 > /usr/src/linux-headers-4.4.0-97-generic/include/linux/sysfs.h:517:37: > error: pointer targets in passing argument 2 of =E2=80=98kernfs_find_and_= get=E2=80=99 > differ in signedness [-Werror=3Dpointer-sign] > return kernfs_find_and_get(parent, name); >=20 > Signed-off-by: Ferruh Yigit Applied, thanks Note: this script does not always remove its temporary files. We need to add a shell trap to catch early exit and do the cleanup.