From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 3/5] bbdev: test applications
Date: Mon, 11 Dec 2017 11:01:27 -0800
Message-ID: <409ed602-6bc4-d2e2-488d-5c512586173f@intel.com>
References: <1512682857-79467-1-git-send-email-amr.mokhtar@intel.com>
 <1512682857-79467-3-git-send-email-amr.mokhtar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
 pablo.de.lara.guarch@intel.com, niall.power@intel.com,
 chris.macnamara@intel.com
To: Amr Mokhtar <amr.mokhtar@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id BEADF2BAE
 for <dev@dpdk.org>; Mon, 11 Dec 2017 20:01:29 +0100 (CET)
In-Reply-To: <1512682857-79467-3-git-send-email-amr.mokhtar@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/7/2017 1:40 PM, Amr Mokhtar wrote:
> - Full test suite for bbdev
> - Test App works seamlessly on all PMDs registered with bbdev
>  framework
> - A python script is provided to make our life easier

Can you please describe what the script is for?

> - Supports execution of tests by parsing Test Vector files

Can you please describe what are test vector files?

> - Test Vectors can be added/deleted/modified with no need for
>  re-compilation
> - Various Tests can be executed:
>  (a) Throughput test
>  (b) Offload latency test
>  (c) Operation latency test
>  (d) Validation test
>  (c) Sanity checks
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

<...>

> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +ifeq ($(CONFIG_RTE_TEST_BBDEV),y)

You don't need this ifdef I think, although I can see testpmd has it ...

> +
> +#
> +# library name
> +#
> +APP = testbbdev
> +
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +
> +#
> +# all sources are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += main.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_perf.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_vector.c

If you remove above wrapping ifdef, you may use CONFIG_RTE_TEST_BBDEV instead.

<...>

> +int
> +unit_test_suite_runner(struct unit_test_suite *suite)

Is test-bbdev application a suit of test cases? What is the benefit of having
separate application comparing adding unit tests to test/ folder?

<...>