From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 05/10] eal: add and use unaligned integer
	types
Date: Mon, 22 Jun 2015 11:36:20 +0200
Message-ID: <4101438.HZvvEl93na@xps13>
References: <1434735293-15469-1-git-send-email-cchemparathy@ezchip.com>
 <1434735293-15469-6-git-send-email-cchemparathy@ezchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Cyril Chemparathy <cchemparathy@ezchip.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 17BA1C7DC
 for <dev@dpdk.org>; Mon, 22 Jun 2015 11:37:22 +0200 (CEST)
Received: by wgbhy7 with SMTP id hy7so136132882wgb.2
 for <dev@dpdk.org>; Mon, 22 Jun 2015 02:37:21 -0700 (PDT)
In-Reply-To: <1434735293-15469-6-git-send-email-cchemparathy@ezchip.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-19 10:34, Cyril Chemparathy:
> On machines that are strict on pointer alignment, current code breaks
> on GCC's -Wcast-align checks on casts from narrower to wider types.
> This patch introduces new unaligned_uint(16|32|64)_t types, which
> correctly retain alignment in such cases.
[...]
> +#ifdef RTE_ARCH_STRICT_ALIGN
> +typedef uint64_t unaligned_uint64_t __attribute__ ((aligned(1)));
> +typedef uint32_t unaligned_uint32_t __attribute__ ((aligned(1)));
> +typedef uint16_t unaligned_uint16_t __attribute__ ((aligned(1)));
> +#else
> +typedef uint64_t unaligned_uint64_t;
> +typedef uint32_t unaligned_uint32_t;
> +typedef uint16_t unaligned_uint16_t;
> +#endif

CONFIG_RTE_ARCH_STRICT_ALIGN should be declared (and disabled) in config templates.