From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: announce API change in crypto driver allocation Date: Tue, 08 Aug 2017 12:21:24 +0200 Message-ID: <4111935.LCpq9MAlqe@xps> References: <20170803010236.17503-1-pablo.de.lara.guarch@intel.com> <0b8b13ec-9989-f10e-bfa2-7415446361a5@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Akhil Goyal , jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, fiona.trahe@intel.com, deepak.k.jain@intel.com, john.griffin@intel.com, declan.doherty@intel.com To: Pablo de Lara Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DF8F42BE9 for ; Tue, 8 Aug 2017 12:21:40 +0200 (CEST) In-Reply-To: <0b8b13ec-9989-f10e-bfa2-7415446361a5@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/08/2017 12:43, Akhil Goyal: > On 8/3/2017 6:32 AM, Pablo de Lara wrote: > > rte_cryptodev_allocate_driver() function gets one parameter > > (rte_driver), as the cryptodev_driver structure is > > allocated inside the function with rte_malloc. > > > > This function is called from a constructor function, > > when crypto PMDs are registered. > > If malloc fails, there is no way to recover from it, > > so it is better to allocate this structure > > statically, in each PMD. > > > > Therefore, it is required to add an extra parameter in > > this function, to also get a pointer to this structure. > > > > Signed-off-by: Pablo de Lara > > > Acked-by: Akhil Goyal Applied, thanks