From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 0/2] ethdev: debug code cleanup Date: Wed, 25 Nov 2015 19:21:13 +0100 Message-ID: <4113213.2gBx8RUJNc@xps13> References: <1447762867-32124-1-git-send-email-bruce.richardson@intel.com> <1448386677-1441-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 463649578 for ; Wed, 25 Nov 2015 19:22:32 +0100 (CET) Received: by wmvv187 with SMTP id v187so269750516wmv.1 for ; Wed, 25 Nov 2015 10:22:32 -0800 (PST) In-Reply-To: <1448386677-1441-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-24 17:37, Bruce Richardson: > This patchset performs two cleanups: > 1. Four functions in ethdev.c which were enabled for debug only have been > merged into their inlined header-file counterparts. This change required that > a number of macros be renamed and moved to the header file too. The macro changes > are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3. > 2. Checks for valid function pointers are added to the API calls for reading > the descriptor ring count, and checking for a valid descriptor. This is because > these functions are not implemented by most drivers, and so it's far safer to > have the check. > > NOTE: This patchset now depends upon the cryptodev patchset Applied with small changes, thanks