From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] ether: fix overwriting driver-specific stats Date: Fri, 22 Jul 2016 00:15:58 +0200 Message-ID: <4141012.DoPZBfDE7d@xps13> References: <1468926317-2988-1-git-send-email-remy.horton@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 500315A40 for ; Fri, 22 Jul 2016 00:16:00 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id o80so42249297wme.1 for ; Thu, 21 Jul 2016 15:16:00 -0700 (PDT) In-Reply-To: <1468926317-2988-1-git-send-email-remy.horton@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-19 12:05, Remy Horton: > After doing a driver callout to fill in the driver specific > parts of struct rte_eth_stats, rte_eth_stats_get() overwrites > the rx_nombuf member regardless of whether the driver itself > has assigned a value. Any driver-assigned value should take > priority. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Remy Horton Applied, thanks