From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] port: fix build when KNI support is not enabled Date: Mon, 27 Jun 2016 12:25:15 +0200 Message-ID: <4144844.UPsiVPEqBF@xps13> References: <191edb8105649612fab5f0e691f587715b78e664.1466595242.git.pmatilai@redhat.com> <3EB4FA525960D640B5BDFFD6A3D8912647A0C1E6@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Dumitrescu, Cristian" , zhuangwj@gmail.com To: Panu Matilainen Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id B156E58D4 for ; Mon, 27 Jun 2016 12:25:16 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v199so93946132wmv.0 for ; Mon, 27 Jun 2016 03:25:16 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A0C1E6@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Commit 9fc37d1c071c is missing a conditional in the dependencies, > > causing builds to fail when KNI is not enabled: > > == Build lib/librte_port > > LD librte_port.so.3 > > /usr/bin/ld: cannot find -lrte_kni > > collect2: error: ld returned 1 exit status > > > > Fixes: 9fc37d1c071c ("port: support KNI") > > > > Signed-off-by: Panu Matilainen > > Acked-by: Cristian Dumitrescu Applied, thanks A cleanup of the makefiles is welcome, as discussed in this thread, to remove useless reference to their own config variable.