From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 2/4] change root makefile license to SPDX
	tag
Date: Mon, 18 Dec 2017 17:30:26 +0100
Message-ID: <4147827.fBL4TnQB7r@xps>
References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com>
 <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com>
 <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org,
 stephen@networkplumber.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D3D6B23D
 for <dev@dpdk.org>; Mon, 18 Dec 2017 17:30:28 +0100 (CET)
In-Reply-To: <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/12/2017 16:52, Bruce Richardson:
> On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote:
> > --- a/GNUmakefile
> > +++ b/GNUmakefile
> > @@ -1,33 +1,6 @@
> > -#   BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> >  #
> >  #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> 
> Actually, minor comment, can we remove the blank line between the SPDX
> identifier and the copyright? Given that in the majority of cases, we
> will only have one line each, having a space between them is a) probably
> unnecessary, and b) looks weird IMHO.
> 
> I'm currently working on a patchset to update the meson.build files, and
> I think having:
> 
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
> 
> looks better as a header than two one-line paragraphs.

+1, I agree with Bruce