From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] virtio: fix wrong queue index for
	VIRTIO_PCI_QUEUE_SEL
Date: Wed, 09 Dec 2015 21:09:27 +0100
Message-ID: <4152327.aAbH2kO9Wx@xps13>
References: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 6DCAA5A4D
 for <dev@dpdk.org>; Wed,  9 Dec 2015 21:10:43 +0100 (CET)
Received: by wmuu63 with SMTP id u63so238058116wmu.0
 for <dev@dpdk.org>; Wed, 09 Dec 2015 12:10:43 -0800 (PST)
In-Reply-To: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-08 11:05, Yuanhan Liu:
> We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx,
> but not vq->queue_id.
> 
> vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(),
> which always starts from 0 no matter which queue it is. However,
> for virtio, even number is for RX queue, and odd number is for
> TX queue.
> 
> Fixes: 5382b188fb8a ("virtio: add queue release")
> 
> Cc: Bernard Iremonger <bernard.iremonger@intel.com>

Bernard was not CC'ed.

> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Applied, thanks