From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: add script to verify map files
Date: Sun, 27 May 2018 22:50:58 +0200
Message-ID: <4156041.IfarTdeXU8@xps>
References: <20180212161312.31795-1-pbhagavatula@caviumnetworks.com>
 <9253aa4f-17d2-53f7-8b57-4a9b5d6e1f53@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4862037AF
 for <dev@dpdk.org>; Sun, 27 May 2018 22:51:01 +0200 (CEST)
In-Reply-To: <9253aa4f-17d2-53f7-8b57-4a9b5d6e1f53@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Sorry for having missed this patch during so long.

13/02/2018 11:48, Ferruh Yigit:
> On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > This script checks for the symbols specified in the map files against
> > the symbols present in the map file directory.
> > Currently, the script checks for map files in drivers and lib directory.
> > 
> > Example:
> > ./devtools/check-map.py
> > 
> > The following symbols are unused :
> > 
> > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > ['rte_dpaa_pool_table']
> > 
> > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > ['qbman_get_version', 'qbman_swp_send_multiple']
> > 
> > ...
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> +1 to improve our tools.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

I agree we must have more tools.

I think this check can be a lot simpler as a shell script,
instead of Python. It does not need the list features of Python.

I've run it and I see it does not catch symbols which are renamed
with a prefix. Example:
	vfio_get_group_fd became rte_vfio_get_group_fd