From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: Fix examples install path Date: Wed, 23 Dec 2015 22:37:45 +0100 Message-ID: <4157952.R3xvfQ6Lix@xps13> References: <1450789995-23700-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id CDA015A9D for ; Wed, 23 Dec 2015 22:39:29 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id p187so161047605wmp.1 for ; Wed, 23 Dec 2015 13:39:29 -0800 (PST) In-Reply-To: <1450789995-23700-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2015-12-22 14:13, Christian Ehrhardt: > Depending on non-doc targets being built before and the setting of DESTDIR > the examples dir could in some cases not end up in the right target. > Reason is just a typo variable reference in the copy target. [...] > - $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) > + $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(docdir) No, it was not a typo. Do you really think the examples code should be in the doc dir (i.e. /usr/share/doc/dpdk) instead of datadir (i.e. /usr/share/dpdk)?