From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: update new ethdev offload API
	description
Date: Wed, 21 Mar 2018 15:08:21 +0100
Message-ID: <4165486.q6vGXG96hz@xps>
References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com>
 <5efda914-7017-9095-2546-ae6e4c627295@solarflare.com>
 <4a4330be-a8c4-599d-d8a7-3703e5af285c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, Patil@dpdk.org,
 Harish <harish.patil@cavium.com>, Ivan Malov <Ivan.Malov@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 73F7056A1
 for <dev@dpdk.org>; Wed, 21 Mar 2018 15:08:39 +0100 (CET)
In-Reply-To: <4a4330be-a8c4-599d-d8a7-3703e5af285c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/03/2018 11:54, Ferruh Yigit:
> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote:
> > IMHO, it should be allowed to specify queue offloads on port level.
> > It should simply enable these offloads on all queues. Also it will
> > match dev_info [rt]x_offload_capa which include both port and queue
> > offloads.
> > 
> > Yes, we lose possibility to enable on port level, but disable on queue
> > level by suggested changes, but I think it is OK - if you don't need
> > it for all queues, just control separately on queue level.
> 
> What I understand was queue offload can only enable more, but it seems it can
> both enable or disable.

Yes, queue offload should only enable more.
An offload enabled at port level, cannot be disabled at queue level.
A port offload can be repeated in queue configuration.
If a port offload is not repeated in queue configuration, there should be
no impact: it is still in the port configuration, thus applying to all queues.

About capabilities, the queue offloads must be a subset of port offloads.
The queue capabilities show which offloads can be enabled per queue.