From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/4]ethdev: add ethdev APIs for NIC filters of generic filter Date: Tue, 27 May 2014 11:18:34 +0200 Message-ID: <4169898.AcYyTuYMh1@xps13> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <1400895442-32433-2-git-send-email-jingjing.wu@intel.com> <0976FC66838DDE4585886952506C9436FBA620@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ming, LiX" Return-path: In-Reply-To: <0976FC66838DDE4585886952506C9436FBA620-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi LiX, Thanks for testing patches. In order to be more efficient next times, I have same comments as for HuilongX. 2014-05-27 07:57, Ming, LiX: > This patch adds APIs for NIC filters list below: > ethertype filter, syn filter, 2tuple filter, flex filter, 5tuple filter 1) When replying to an email, there should be "> " in front of lines you have not written. Here, it's not easy to see what you are replying. > Test-by: lmingX lix,ming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org 2) If you do some tests (other than compiling), please explain what are the tests (command lines and environment). > Compile pass 3) No need to notify that compilation is working. It's implicit (and mandatory) when sending a patch. > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index a5727dd..afd4fe8 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c 4) Please do not copy all the patch if you have nothing specific to say about it. Thanks for your help -- Thomas