From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] ixgbe: support X540 VF
Date: Thu, 11 Dec 2014 00:23:24 +0100
Message-ID: <4172805.tCufcf6XqG@xps13>
References: <20141209083724.1a6872ac@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20141209083724.1a6872ac@urahara>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-12-09 08:37, Stephen Hemminger:
> Add missing setup for X540 MAC type when setting up VF.
> Additional check exists in Linux driver but not in DPDK.
> 
> Signed-off-yb: Bill Hong <bhong-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> 
> Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
> 
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c	2014-12-08 09:26:18.150170081 -0800
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c	2014-12-08 09:26:18.150170081 -0800
> @@ -1911,7 +1911,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_
>  	/*
>  	 * Modification to set VFTDT for virtual function if vf is detected
>  	 */
> -	if (hw->mac.type == ixgbe_mac_82599_vf)
> +	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_X540_vf)

What about X550? Should it be listed there?

>  		txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
>  	else
>  		txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
> @@ -2198,7 +2199,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_
>  	/*
>  	 * Modified to setup VFRDT for Virtual Function
>  	 */
> -	if (hw->mac.type == ixgbe_mac_82599_vf) {
> +	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_X540_vf) {
>  		rxq->rdt_reg_addr =
>  			IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
>  		rxq->rdh_reg_addr =

It appears to be a fix which is candidate for 1.8.0.

Thanks
-- 
Thomas