From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 4/5] hash: add lock-free read-write concurrency Date: Tue, 06 Nov 2018 10:13:53 +0100 Message-ID: <4202399.UOW9WdkMPh@xps> References: <1540532253-112591-1-git-send-email-honnappa.nagarahalli@arm.com> <20181106090953.GA5671@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Honnappa Nagarahalli , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "yipeng1.wang@intel.com" , Dharmik Thakkar , "Gavin Hu (Arm Technology China)" , nd , "ferruh.yigit@intel.com" , "hemant.agrawal@nxp.com" , "chaozhu@linux.vnet.ibm.com" , "Kapoor, Prasun" To: Jerin Jacob Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 38E7414EC for ; Tue, 6 Nov 2018 10:13:58 +0100 (CET) In-Reply-To: <20181106090953.GA5671@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/11/2018 10:10, Jerin Jacob: > From: Honnappa Nagarahalli > > Jerin, thank you for running this test and all the analysis. I have not run this test. I was focused on simultaneous reads and writes. You can look at file test_hash_readwrite_lf.c to look for the kind of the use cases. > > > > I am trying to reproduce this, I will get back with more details soon. > > OK. Since RC2 approaching, bit worried about next steps if we cannot > avoid the regression with this new feature for this release. 18.11-rc2 is already out. > 24% drop of performance regression not seen in past for a specific > usecase.So not sure what we did past for similar situations. > > Thomas, > Any thought of this? Everything is possible, you just need to agree on a patch. Please let's fix (or disable or revert) it in -rc3 this week.