From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 00/17] Generic devargs parsing
Date: Sun, 09 Jul 2017 12:17:42 +0200
Message-ID: <4219460.8ez8IeSCfv@xps>
References: <cover.1499211959.git.gaetan.rivet@6wind.com>
 <3893726.oUZ9cfT8R6@xps>
 <CALe+Z00_K_7V8=PNaFOLB3u2Pq_L-nTg+ngFfkoNu4NhRbgk+Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Jan Blunck <jblunck@infradead.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BF28858CE
 for <dev@dpdk.org>; Sun,  9 Jul 2017 12:17:44 +0200 (CEST)
In-Reply-To: <CALe+Z00_K_7V8=PNaFOLB3u2Pq_L-nTg+ngFfkoNu4NhRbgk+Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/07/2017 10:37, Jan Blunck:
> On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 07/07/2017 02:04, Gaetan Rivet:
> >> In this patchset, the representation of devices in rte_devargs is made generic
> >> to remove some dependencies of the EAL on specific buses implementations.
> >> Following the device types being characterized by their bus, the DEVTYPE
> >> flags are updated not to reference virtual / PCI devices anymore.
> > [...]
> >> Gaetan Rivet (16):
> >>   net/bonding: properly reference PCI header
> >>   net/bnxt: properly reference PCI header
> >>   net/mlx5: properly reference PCI header
> >>   net/e1000: properly reference PCI header
> >>   net/ixgbe: properly reference PCI header
> >>   net/sfc: properly reference PCI header
> >>   app/testpmd: properly reference PCI header
> >>   test: properly reference PCI header
> >>   dev: device kernel module is a device attribute
> >>   bus: introduce bus scan policies
> >>   devargs: parse bus policies
> >>   devargs: generic device representation
> >>   net/virtio: do not reference device type
> >>   devargs: generic device types
> >>   devargs: introduce cleaner parsing helper
> >>   eal: change whitelist / blacklist command line doc
> >>
> >> Thomas Monjalon (1):
> >>   examples/ethtool: properly reference PCI header
> >
> > Series applied, except last patch (17), as explained before. Thanks
> >
> 
> I wonder why you complain about not having enough reviewers if you
> anyway ignoring their feedback!

I am not ignoring your feedback at all.
There are 2 things in this series:
	1/ decouple devargs and PCI/vdev
	2/ couple devargs policies to rte_bus
I agree that we should not have policies in rte_bus (2).
However it is the only patches we have for now to achieve (1),
which is a required step to move PCI and vdev as real bus drivers.

As explained in the following email, I prefer progressing on (1)
and rework (2) in 17.11:
	http://dpdk.org/ml/archives/dev/2017-July/070203.html
What do you think of my proposal, adding a callback in probe?

> I pointed out multiple times that parsing a device name to deduce the
> bus is not the right thing to do.

Yes, so we need to change the parameter syntax to make the bus name
explicit and mandatory. We need a deprecation notice.

> This series also tightly couples rte_devargs to rte_bus.
> It adds hidden functionality to have
> blacklist/whitelist mode for all busses and even sticks that
> functionality on the wrong object (devargs).

Yes, as said above, we must rework it in 17.11.