From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 00/13] net/sfc: fix device reconfigure
Date: Fri, 31 Mar 2017 16:31:43 +0100
Message-ID: <4219af0c-aec0-c1fa-9cba-cae62c0e52eb@intel.com>
References: <1490955743-9868-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id D4BCC2BA4
 for <dev@dpdk.org>; Fri, 31 Mar 2017 17:31:46 +0200 (CEST)
In-Reply-To: <1490955743-9868-1-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/31/2017 11:22 AM, Andrew Rybchenko wrote:
> When I implemented initial version of the driver I had incorrect
> understanding of the required state transition to reconfigure
> device. It was assumed that close is required before reconfigure.
> Looking at description in rte_ethdev.h, rte_eth_dev_close()
> description and rte_eth_dev_configure() implementation I see that
> I was wrong.
> 
> If reconfigure attempt is done without the patch series, testpmd
> crashes on segmentation fault. The patch series fixes it. So,
> technically it is a bug fix, but unfortunately pretty big.
> 
> The patch series should be applied after [1] (patch [2]).
> 
> Testing the patch requires [3] (patch [4]). Intel compilation of
> the patch fails since it is applied to dpdk.git tree instead of
> dpdk-next-net.git.
> 
> [1] http://dpdk.org/ml/archives/dev/2017-March/062155.html
> [2] http://dpdk.org/dev/patchwork/patch/22758/
> [3] http://dpdk.org/ml/archives/dev/2017-March/062157.html
> [4] http://dpdk.org/dev/patchwork/patch/22756/
> 
> Andrew Rybchenko (13):
>   net/sfc: clarify interrupts support function names
>   net/sfc: bind EvQ DMA space to EvQ type and type-local index
>   net/sfc: remove unused max entries from EvQ info
>   net/sfc: move EvQ entries to the EvQ control structure
>   net/sfc: remove flags from EvQ info
>   net/sfc: remove EvQ info array to simplify reconfigure
>   net/sfc: move event support init to attach stage
>   net/sfc: initialize port data on attach
>   net/sfc: clarify Rx subsystem configure/close function names
>   net/sfc: clarify Tx subsystem configure/close function names
>   net/sfc: support changing the number of receive queues
>   net/sfc: support changing the number of transmit queues
>   net/sfc: fix device reconfigure

Series applied to dpdk-next-net/master, thanks.