From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH 2/2] mempool: fix comments for no contiguous
	flag
Date: Wed, 21 Sep 2016 17:12:12 +0200
Message-ID: <4227c29d-30b3-6c8f-46cb-6aba60add843@6wind.com>
References: <20160920161708.9707-1-ferruh.yigit@intel.com>
 <20160920161708.9707-2-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 81D235589
 for <dev@dpdk.org>; Wed, 21 Sep 2016 17:12:18 +0200 (CEST)
In-Reply-To: <20160920161708.9707-2-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On 09/20/2016 06:17 PM, Ferruh Yigit wrote:
> Fixes: ce94a51ff05c ("mempool: add flag for removing phys contiguous constraint")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_mempool/rte_mempool.c | 4 +++-
>  lib/librte_mempool/rte_mempool.h | 3 +++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
> index e96d14f..d767f39 100644
> --- a/lib/librte_mempool/rte_mempool.c
> +++ b/lib/librte_mempool/rte_mempool.c
> @@ -340,7 +340,9 @@ rte_mempool_free_memchunks(struct rte_mempool *mp)
>  }
>  
>  /* Add objects in the pool, using a physically contiguous memory
> - * zone. Return the number of objects added, or a negative value
> + * zone if MEMPOOL_F_NO_PHYS_CONTIG flag is not set.
> + *
> + * Return the number of objects added, or a negative value
>   * on error.
>   */
>  int
> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
> index 6fc331a..291c168 100644
> --- a/lib/librte_mempool/rte_mempool.h
> +++ b/lib/librte_mempool/rte_mempool.h
> @@ -798,6 +798,9 @@ rte_mempool_free(struct rte_mempool *mp);
>   * Add a virtually and physically contiguous memory chunk in the pool
>   * where objects can be instanciated.
>   *
> + * mempool flag MEMPOOL_F_NO_PHYS_CONTIG changes behavior of the function
> + * and removes physical contiguous constraint.
> + *
>   * @param mp
>   *   A pointer to the mempool structure.
>   * @param vaddr
> 

Not sure I'm getting why you add these comments, as I don't see any
usage of MEMPOOL_F_NO_PHYS_CONTIG in rte_mempool_populate_phys().

Could you describe what makes you think the API comments are wrong here?

Thanks,
Olivier