From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-techboard] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library() Date: Mon, 07 Jan 2019 18:03:30 +0100 Message-ID: <4262310.sn7WroDi98@xps> References: <20190103175725.5836-1-bluca@debian.org> <1546879174.6022.24.camel@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: techboard@dpdk.org, Luca Boccassi , dev@dpdk.org, stable@dpdk.org To: Bruce Richardson Return-path: In-Reply-To: <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/01/2019 17:55, Bruce Richardson: > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > However, in > > > conjunction with meson version checks, I believe this was done this > > > way > > > originally because of a meson bug which caused recursive dependencies > > > for > > > things like this to get duplicated many times in the build.ninja > > > file. > > > > > > https://github.com/mesonbuild/meson/issues/2150 > > > > > > If we take the approach of adding bsd explicitly using dependency > > > object > > > our minimum version needs to have the fix for this bug included. > > > > Ah that's not nice. Just verified, and it happens with dependency() as > > well as find_library(). It was fixed in 0.47.1. > > > > Yep, it was a right royal pain when I was doing the original work. Now that > there is a fix in, we can do cleanups like you suggest if we are prepared > to bump our minimum version. > > I'll refer back to the key question here: > "Is it reasonable to ask users compiling DPDK to pull meson from pip rather > than using the distro built-in version?" > [Adding techboard on CC, in the hopes they might have some thoughts] > > If it is ok for most folks, and personally I don't think it's a big deal, > then that gives us a faster path forward. If not, we raise the minimum more > slowly, and keep the existing way of managing the dependencies for a while > longer. Worst case, I'd still hope by 19.11 LTS for us to have minimum > 0.47.1 to have the fix in question. Please, could you describe what are the meson versions in major distros?