From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] vfio: Fix vfio disable INTx
Date: Thu, 30 Mar 2017 17:00:14 +0200
Message-ID: <4264918.VdEWygDdWb@xps13>
References: <1490742934-30608-1-git-send-email-nikhil.rao@intel.com>
 <1490745247-32001-1-git-send-email-nikhil.rao@intel.com>
 <C6ECDF3AB251BE4894318F4E451236978220A553@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Rao, Nikhil" <nikhil.rao@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com
 [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id ECCA8F60E
 for <dev@dpdk.org>; Thu, 30 Mar 2017 17:00:16 +0200 (CEST)
Received: by mail-lf0-f44.google.com with SMTP id z15so28950429lfd.1
 for <dev@dpdk.org>; Thu, 30 Mar 2017 08:00:16 -0700 (PDT)
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236978220A553@IRSMSX109.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-28 15:28, Burakov, Anatoly:
> > From: Rao, Nikhil
> > Sent: Wednesday, March 29, 2017 12:54 AM
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2] vfio: Fix vfio disable INTx
> > 
> > The flags member of irq_set should be ORed with
> > VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK.
> > The bug was found by code inspection.
> > 
> > Fixes: 5c782b3928b8 (\"vfio: interrupts\")
> > 
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> 
> Great find!
> 
> Acked-by: Anatoly  Burakov <anatoly.burakov@intel.com>

Applied, thanks