From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69781C7618F for ; Thu, 18 Jul 2019 22:15:46 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D390B21849 for ; Thu, 18 Jul 2019 22:15:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="C1oqiUJB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="rDih//Le" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D390B21849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6BC42082; Fri, 19 Jul 2019 00:15:43 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 185903DC for ; Fri, 19 Jul 2019 00:15:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C5A8D4E1; Thu, 18 Jul 2019 18:15:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Jul 2019 18:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=yK9UOGK2slJl98Lz8+MkMA/Ljx5wqxDN7eSNK5vIwXg=; b=C1oqiUJBA7vZ T6ZNwRJkLHSZzTvrPqTZs70cA/Y8XNB929k5+z0BdP0gxTtG8UrxsAWFvo1kLAC7 BWhiFiJ/N1vRJzhvto0zVKT5+x0syMFJS4W2aCZvDQyWJB35mbeIC/ZRzDtXdEXF JI1+oo2L+hAKwgvAAMiiLVnun+2mulk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yK9UOGK2slJl98Lz8+MkMA/Ljx5wqxDN7eSNK5vIw Xg=; b=rDih//Lex+KBrEvaI/bdHZAAvk5sPc4jeatfqsvdNjDsdYJoHXxgFbPWI oJwyfcHQHfcU/0hSkJz3l+cyjzm5aWniXEeu1tcX9HKXoe1ToawZ1i+UHbq6NABM 8O85XbVVNALTrtcu7MMWgzeL2Q00jWZ53IYFkWBaHujJ1plZKztsrKRLXQqHTQoR Ms4XIZQQfd71ucpjBFFGyy8nvhyiInYXXs/1AtNfsAafiUlCbxpBngh2eAJS0HW+ qD1EYTA8GZli7J+w+8t/JxrDcobJ+NwPgxhf2vYVUeBm6gU3akwx71wylKmqxI5K kfbX8YGBQn/C29Tb4DYbFne0LVZcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieeigddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 35E008005A; Thu, 18 Jul 2019 18:15:39 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru Date: Fri, 19 Jul 2019 00:15:38 +0200 Message-ID: <4282799.utyVYafb7O@xps> In-Reply-To: References: <20190717184013.1072-1-pbhagavatula@marvell.com> <20190718065111.1766-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > From: Pavan Nikhilesh > > > > Since direct register access is used in npa_lf_aura_op_alloc_bulk() use > > __rte_noinline instead of __rte_always_inline to preserve ABI. > > Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined > > differently which may lead to undefined behaviour due to handcoded asm. > > > > Fixes: 29893042c29d ("mempool/octeontx2: fix clang build for arm64") > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Jerin Jacob Applied, thanks