From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] eal: fix invalid memory read as reported by
	valgrind
Date: Fri, 27 Jun 2014 02:56:48 +0200
Message-ID: <4288998.3pALjXkCDh@xps13>
References: <1403794474-17695-1-git-send-email-aaron@arbor.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1403794474-17695-1-git-send-email-aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-06-26 10:54, Aaron Campbell:
> ==29880== Invalid read of size 1
> ==29880==    at 0x56FF9A5: cpu_socket_id (eal_lcore.c:101)
> ==29880==    by 0x56FFAE9: rte_eal_cpu_init (eal_lcore.c:168)
> ==29880==    by 0x56F944A: rte_eal_init (eal.c:975)
> 
> The problem is that endptr points to memory allocated underneath the DIR
> handle, which has already been freed.  So move the closedir() call lower.
> 
> Signed-off-by: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>

Good catch!

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied for version 1.7.0.

Thanks
-- 
Thomas