From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 2/6] eal/memory: rename buf physaddr to
	buf iovaaddr
Date: Mon, 23 Oct 2017 22:15:02 +0200
Message-ID: <4299450.srK9Y67Yii@xps>
References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com>
 <20171020123136.10557-1-santosh.shukla@caviumnetworks.com>
 <20171020123136.10557-3-santosh.shukla@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com, anatoly.burakov@intel.com
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 614941B6AF
 for <dev@dpdk.org>; Mon, 23 Oct 2017 22:15:04 +0200 (CEST)
In-Reply-To: <20171020123136.10557-3-santosh.shukla@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/10/2017 14:31, Santosh Shukla:
> Rename buf_physaddr to buf_iovaaddr
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
[...]
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -411,7 +411,7 @@ struct rte_mbuf {
>  	 * same mbuf cacheline0 layout for 32-bit and 64-bit. This makes
>  	 * working on vector drivers easier.
>  	 */
> -	iova_addr_t buf_physaddr __rte_aligned(sizeof(iova_addr_t));
> +	iova_addr_t buf_iovaaddr __rte_aligned(sizeof(iova_addr_t));

I really do not understand this naming scheme.
The "A" of IOVA means Address. So "addr" in iovaaddr is redundant.

It seems that IOVA is a too much famous acronym to avoid it.
Unfortunately, there is no justification in the commit message.
For the record, my preference was "IO address".

We could at least add an underscore in iova_addr.

But I will apply it as is because nobody else complained.