DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, eperezma@redhat.com, maxime.coquelin@redhat.com,
	stephen@networkplumber.org
Subject: Re: [PATCH v2] uapi: update headers to v6.19
Date: Fri, 02 Oct 2026 11:46:21 +0200	[thread overview]
Message-ID: <42IOfTxsQM-Md_-aO3EZGA@monjalon.net> (raw)
In-Reply-To: <20261001090558.1131763-1-david.marchand@redhat.com>

01/10/2026 11:05, David Marchand:
> --- a/devtools/linux-uapi.sh
> +++ b/devtools/linux-uapi.sh
> @@ -13,6 +13,9 @@ file=""
>  check_headers=false
>  quiet=false
>  
> +# Require unifdef
> +unifdef -h >/dev/null 2>&1 || { echo "This script requires unifdef."; exit 1; }

Do you need to send the message to stderr?


> --- a/drivers/net/nbl/nbl_common/nbl_userdev.c
> +++ b/drivers/net/nbl/nbl_common/nbl_userdev.c
> @@ -2,8 +2,9 @@
>   * Copyright 2025 Nebulamatrix Technology Co., Ltd.
>   */
>  
> -#include "nbl_userdev.h"
>  #include <uapi/linux/vfio.h>
> +
> +#include "nbl_userdev.h"
>  #include <rte_vfio.h>

This is tricky.
Is it documented that uAPI headers should be included first?



  parent reply	other threads:[~2026-10-02  9:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  9:57 [PATCH 0/2] uapi: introduce compatibility define of old compilers Maxime Coquelin
2026-09-30  9:57 ` [PATCH 1/2] config: add compatibility for old compilers with new UAPI headers Maxime Coquelin
2026-09-30 15:26   ` Stephen Hemminger
2026-09-30 15:37     ` Maxime Coquelin
2026-10-01  8:19       ` David Marchand
2026-10-01  8:30         ` Maxime Coquelin
2026-09-30  9:58 ` [PATCH 2/2] uapi: update headers to v6.19 Maxime Coquelin
2026-09-30 15:27   ` Stephen Hemminger
2026-09-30 15:38     ` Maxime Coquelin
2026-10-01  9:05 ` [PATCH v2] " David Marchand
2026-10-01 14:12   ` Maxime Coquelin
2026-10-01 16:05   ` Stephen Hemminger
2026-10-02  9:46   ` Thomas Monjalon [this message]
2026-10-02  9:59     ` David Marchand
2026-10-03  9:45   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42IOfTxsQM-Md_-aO3EZGA@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=eperezma@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox