From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 1/5] net/af_xdp: introduce AF XDP PMD
	driver
Date: Fri, 29 Mar 2019 08:10:55 +0000
Message-ID: <42dfd66b-7417-f140-c60f-8896e6350c0b@intel.com>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190327090027.72170-1-xiaolong.ye@intel.com>
 <20190327090027.72170-2-xiaolong.ye@intel.com>
 <e82e995f-400c-1081-5279-b657fa168665@intel.com>
 <20190329020505.GB92946@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Karlsson Magnus <magnus.karlsson@intel.com>,
 Topel Bjorn <bjorn.topel@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Luca Boccassi <bluca@debian.org>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ananyev Konstantin <konstantin.ananyev@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 7E84D2BD3
 for <dev@dpdk.org>; Fri, 29 Mar 2019 09:11:00 +0100 (CET)
In-Reply-To: <20190329020505.GB92946@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/29/2019 2:05 AM, Ye Xiaolong wrote:
>> <...>
>>
>>> +static void
>>> +eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>>> +{
>>> +	struct pmd_internals *internals = dev->data->dev_private;
>>> +
>>> +	dev_info->if_index = internals->if_index;
>>> +	dev_info->max_mac_addrs = 1;
>>> +	dev_info->max_rx_pktlen = ETH_FRAME_LEN;
>>> +	dev_info->max_rx_queues = 1;
>>> +	dev_info->max_tx_queues = 1;
>> What do you think documenting the only single queue supported limitation?
> I've mentioned the single queue limitation in af_xdp.rst, or you mean we also
> need to comment it here?
> 

I missed it in af_xdp.rst, if documented there I think it is OK.