From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] net/failsafe: fix FreeBSD build Date: Tue, 13 Feb 2018 23:20:46 +0100 Message-ID: <4305556.A2Klv6Z1yo@xps> References: <20180213213312.22225-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "gaetan.rivet@6wind.com" To: Matan Azrad , "De Lara Guarch, Pablo" Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4A0B31B311 for ; Tue, 13 Feb 2018 23:20:57 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > The type pthread_t is not portable because it is freely defined. > > > On Linux, it is an unsigned long int which can be printed with %l. > > > On FreeBSD, it is a pointer which can be printed with %p. > > > > > > That's why there was this error: > > > drivers/net/failsafe/failsafe_private.h:377:53: error: > > > format specifies type 'unsigned long' but the argument has > > > type 'pthread_t' (aka 'struct pthread *') > > > > > > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") > > > > > > Reported-by: Pablo de Lara > > > Signed-off-by: Thomas Monjalon > > > > Tested-by: Pablo de Lara > > > Acked-by: Matan Azrad Applied