From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 3/4] net/virtio: don't use simple Rx path if
 TCP LRO requested
Date: Tue, 5 Jun 2018 15:39:06 +0200
Message-ID: <4310f98c-2a1a-933b-ee6c-d9620dcf5166@redhat.com>
References: <20180601124758.22652-1-maxime.coquelin@redhat.com>
 <20180601124758.22652-4-maxime.coquelin@redhat.com>
 <20180604115903.GB21406@debian>
 <9efa2c4c-a391-49d1-2444-7c1a70468a71@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: zhihong.wang@intel.com, dev@dpdk.org
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 96D021B861
 for <dev@dpdk.org>; Tue,  5 Jun 2018 15:39:10 +0200 (CEST)
In-Reply-To: <9efa2c4c-a391-49d1-2444-7c1a70468a71@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 06/04/2018 04:32 PM, Maxime Coquelin wrote:
> 
> 
> On 06/04/2018 01:59 PM, Tiwei Bie wrote:
>> On Fri, Jun 01, 2018 at 02:47:57PM +0200, Maxime Coquelin wrote:
>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> ---
>>>   drivers/net/virtio/virtio_ethdev.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/virtio/virtio_ethdev.c 
>>> b/drivers/net/virtio/virtio_ethdev.c
>>> index 5730620ed..d481b282e 100644
>>> --- a/drivers/net/virtio/virtio_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_ethdev.c
>>> @@ -1893,7 +1893,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)
>>>       }
>>>       if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
>>> -               DEV_RX_OFFLOAD_TCP_CKSUM))
>>> +               DEV_RX_OFFLOAD_TCP_CKSUM |
>>> +               DEV_RX_OFFLOAD_TCP_LRO))
>>
>> Maybe we also need to consider not using simple Rx
>> when DEV_RX_OFFLOAD_VLAN_STRIP is requested.
> 
> I think that makes sense.

And also the same for Tx when VLAN_INSERT is requested

> Thanks,
> Maxime
> 
>> Best regards,
>> Tiwei Bie
>>
>>>           hw->use_simple_rx = 0;
>>>       if (tx_offloads & (DEV_TX_OFFLOAD_TCP_CKSUM |
>>> -- 
>>> 2.14.3
>>>