From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 0/3] MAC address fail to be added
	shouldn't be stored
Date: Mon, 01 May 2017 00:59:54 +0200
Message-ID: <4318072.gYggGDVejI@xps>
References: <1493525507-56304-1-git-send-email-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, harish.patil@cavium.com,
 rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com,
 helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com,
 jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
 bruce.richardson@intel.com, yuanhan.liu@linux.intel.com,
 maxime.coquelin@redhat.com, shepard.siegel@atomicrules.com,
 ed.czeck@atomicrules.com, john.miller@atomicrules.com
To: Wei Dai <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 37D617CAC
 for <dev@dpdk.org>; Mon,  1 May 2017 00:59:57 +0200 (CEST)
In-Reply-To: <1493525507-56304-1-git-send-email-wei.dai@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

30/04/2017 06:11, Wei Dai:
> Current ethdev always stores MAC address even it fails to be added.
> Other function may regard the failed MAC address valid and lead to
> some errors. So There is a need to check if the addr is added
> successfully or not and discard it if it fails.
> 
> In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count"
> to add more than one MAC address one time.
> This command can simplify the test for the first patch.
> Normally a MAC address may fails to be added only after many MAC
> addresses have been added.
> Without this command, a tester may only trigger failed MAC address
> by running many times of testpmd command 'mac_addr add' .
> 
> For v4 patch set, have got acknowledgement from
> Nelio Laranjeiro <nelio.laranjeiro@6wind.com>  for mlx changes
> Yuanhan Liu <yuanhan.liu@linux.intel.com>  for virtio changes

You have not taken the ack from Konstantin,
and you have again forgot --in-reply-to, so review is hard.

Checkpatch reports:
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files

Please make a perfect v6.