From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] drivers/net/e1000/igb_ethdev.c:fix
	eth_igb_add_del_flex_filter
Date: Fri, 10 Jul 2015 16:48:27 +0200
Message-ID: <4340982.5yr692ncls@xps13>
References: <1432484252-3517-1-git-send-email-motomu@hongo.wide.ad.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: motomu <motomu@hongo.wide.ad.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 90DA5C398
 for <dev@dpdk.org>; Fri, 10 Jul 2015 16:49:36 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so68066503wgx.3
 for <dev@dpdk.org>; Fri, 10 Jul 2015 07:49:36 -0700 (PDT)
In-Reply-To: <1432484252-3517-1-git-send-email-motomu@hongo.wide.ad.jp>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

We definitely need a maintainer for e1000.

2015-05-24 16:17, motomu:
> From: Motomu Utsumi <motomu@hongo.wide.ad.jp>
> 
> in add flexfiler it always write to same register address,
> so when try to adapt some filters only last one is enabled.
> I substitute value based on based on flex_filter->index for reg_off.
> 
> in del flexfilter, it delete target filter and 
> also delete first filter because of similar reason.
> I substitute value based on based on it->index for reg_off.

You forgot a Signed-off.

[...]
>  		}
> +    if (flex_filter->index < E1000_MAX_FHFT)
> +      reg_off = E1000_FHFT(flex_filter->index);
> +    else
> +      reg_off = E1000_FHFT_EXT(flex_filter->index - E1000_MAX_FHFT);

On the formatting side, it seems indent is wrong.