From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] ethdev: return diagnostic when setting
	MAC address
Date: Fri, 6 Apr 2018 17:03:49 +0100
Message-ID: <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com>
References: <20180403124103.13124-1-olivier.matz@6wind.com>
 <20180406153444.23988-1-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, Tomasz Duszynski
 <tdu@semihalf.com>, Andrew Rybchenko <arybchenko@solarflare.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Ivan Malov <ivan.malov@oktetlabs.ru>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 2B66C1D2DC
 for <dev@dpdk.org>; Fri,  6 Apr 2018 18:03:54 +0200 (CEST)
In-Reply-To: <20180406153444.23988-1-olivier.matz@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/6/2018 4:34 PM, Olivier Matz wrote:
> Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> return code is added to notify the caller (librte_ether) if an error
> occurred in the PMD.
> 
> The new default MAC address is now copied in dev->data->mac_addrs[0]
> only if the operation is successful.
> 
> The patch also updates all the PMDs accordingly.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>