From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH] vhost: fix crash on unregistering in client
 mode
Date: Thu, 27 Sep 2018 17:54:08 +0200
Message-ID: <434b53c7-539e-026d-8c0c-9560b0465787@redhat.com>
References: <20180907005307.98363-1-zhouqiang2633@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org
To: Qiang Zhou <zhouqiang2633@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180907005307.98363-1-zhouqiang2633@gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Qiang,

On 09/07/2018 02:53 AM, Qiang Zhou wrote:
> when rte_vhost_driver_unregister delete the connection fd,
> the fd lock will prevent the vsocket to be freed. But when
> vhost_user_msg_handler return error, it will delete vsocket
> conn_list. And then the fd lock will become invalid. So the
> vsocket will be freed in rte_vhost_drivere_unregister and
> the vhost_user_read_cb will reconnect.

I am not sure to understand the problem, could you please
elaborate?

> 
> To fix this:
> move delete vsocket conn after reconnect
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiang Zhou <zhouqiang2633@gmail.com>
> ---
>   lib/librte_vhost/socket.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index d63031747..43da1c51b 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -293,16 +293,16 @@ vhost_user_read_cb(int connfd, void *dat, int *remove)
>   		if (vsocket->notify_ops->destroy_connection)
>   			vsocket->notify_ops->destroy_connection(conn->vid);
>   
> +		if (vsocket->reconnect) {
> +			create_unix_socket(vsocket);
> +			vhost_user_start_client(vsocket);
> +		}
> +
>   		pthread_mutex_lock(&vsocket->conn_mutex);
>   		TAILQ_REMOVE(&vsocket->conn_list, conn, next);
>   		pthread_mutex_unlock(&vsocket->conn_mutex);
>   
>   		free(conn);
> -
> -		if (vsocket->reconnect) {
> -			create_unix_socket(vsocket);
> -			vhost_user_start_client(vsocket);
> -		}
>   	}
>   }
>   
>