From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] ethdev: remove duplicated symbols from .map Date: Thu, 30 Jun 2016 19:58:50 +0200 Message-ID: <4355072.3dvfNtBY6m@xps13> References: <1466860257-4068-1-git-send-email-thomas.monjalon@6wind.com> <1467032551-14979-1-git-send-email-ferruh.yigit@intel.com> <57712511.3020806@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , Cristian Dumitrescu To: Ferruh Yigit Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id EAFE93978 for ; Thu, 30 Jun 2016 19:59:54 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id r201so129841575wme.1 for ; Thu, 30 Jun 2016 10:59:54 -0700 (PDT) In-Reply-To: <57712511.3020806@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Thomas, > > I got the duplicates with following command [1], does it make sense to > add this into one of the check scripts, -not sure which one? > > [1] > # for m in $(find . -name *_version.map); do for l in $(cat $m | sort | > uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";" > -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l; > fi; done; done > I have started to write a script to check symbol export. Feel free to start a new script scripts/check-symbols.sh with this check for duplicated symbols in .map. I will add my checks later in this script. Thanks