From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] drivers: fix to replace strcat with strncat
Date: Tue, 15 Jan 2019 02:53:28 +0100
Message-ID: <4355742.ZHn0J28zhk@xps>
References: <1547445875-24601-1-git-send-email-tallurix.chaitanya.babu@intel.com>
 <20190114142133.GA16996@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>,
 reshma.pattan@intel.com, rmody@marvell.com, shshaikh@marvell.com,
 beilei.xing@intel.com, qi.z.zhang@intel.com, alejandro.lucero@netronome.com,
 pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, stable@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190114142133.GA16996@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/01/2019 15:21, Bruce Richardson:
> On Mon, Jan 14, 2019 at 06:04:35AM +0000, Chaitanya Babu Talluri wrote:
> > Strcat does not check the destination length and there might be
> > chances of string overflow so insted of strcat, strncat is used.
[...]
> 
> While I believe this is correct, this (and the changes below) would be a
> lot neater using strlcat function. We should perhaps look to add strlcat
> alongside strlcpy for DPDK use.

Yes it looks reasonnable.