From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] bus/pci: fix unexpected resource mapping override Date: Mon, 29 Oct 2018 00:26:30 +0100 Message-ID: <4370007.3MeJCCFLt4@xps> References: <20181027032045.7564-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com, stable@dpdk.org, gaetan.rivet@6wind.com, arybchenko@solarflare.com To: Qi Zhang Return-path: In-Reply-To: <20181027032045.7564-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2018 05:20, Qi Zhang: > When scanning an already plugged device, the virtual address > of mapped PCI resource in rte_pci_device will be overridden > with 0, that may cause driver does not work correctly. > The fix is not to update any rte_pci_device's field if the being > scanned device's driver is already probed. >=20 > Bugzilla ID: 85 > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org >=20 > Reported-by: Lv Geoffrey > Signed-off-by: Qi Zhang I still think something must be fixed in PCI scan. Anyway, there is an error: passing argument 1 of =E2=80=98rte_dev_is_probed=E2=80=99 from incompatible= pointer type